fix: paragraph gets treated as comma #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luis-almeida
reviewed
Oct 4, 2024
src/modules/new-request-form/fields/cc-field/useTagsInputContainer.ts
Outdated
Show resolved
Hide resolved
- In French keyboards, the browser is detecting the code for a paragraph to be a comma instead. To fix this, for the outlier of the comma, I'm using the check on key instead of code. Garden has these keys available as constants so I'm using them for consistency on comparison
melzreal
force-pushed
the
melreal/fix-comma-treated-as-paragraph
branch
from
c01b0b4
to
0c01d76
Compare
it was when you checked x) I was just asking Gianluca if we were ok with the approach or wanted consistency, ended up going with consistency for the keys by referring to the Garden constants (cuz e.key for space its just an empty space so it looked a little weird) |
luis-almeida
approved these changes
Oct 4, 2024
BrunoBFerreira
approved these changes
Oct 4, 2024
|
🎉 This PR is included in version 4.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The remaining checks appear consistent across keyboards so I'm going with the minimum change possible
Screenshots
Checklist